Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 22387 - Don't unconditionally override the type of an assert #13168

Merged
merged 1 commit into from Oct 14, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Oct 14, 2021

The type might've already been set before, e.g. by defaultInitLiteral
for const(noreturn).init. Unconditionally setting the type to
noreturn would discard qualifiers and then cause problems in generic
code, e.g. for isBidirectionalRange!(const(noreturn)[]).

The type might've already been set before, e.g. by `defaultInitLiteral`
for `const(noreturn).init`. Unconditionally setting the type to
`noreturn` would discard qualifiers and the cause problems in generic
code, e.g. for `isBidirectionalRange!(const(noreturn)[])`.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22387 normal Noreturn init loses type qualifiers

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13168"

@dlang-bot dlang-bot merged commit 21a6ff1 into dlang:master Oct 14, 2021
@MoonlightSentinel MoonlightSentinel deleted the noreturn/init-type branch October 15, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants