Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 17870 - Can't alias a mix of parent and child class members #13380

Merged
merged 2 commits into from Dec 4, 2021
Merged

Fix Issue 17870 - Can't alias a mix of parent and child class members #13380

merged 2 commits into from Dec 4, 2021

Conversation

12345swordy
Copy link
Contributor

@12345swordy 12345swordy commented Dec 3, 2021

Reboot of the PR #11633
Addressed @wilzbach test requirements

cc @RazvanN7

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @12345swordy! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
17870 normal Can't alias a mix of parent and child class members

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13380"

Fix formating
@RazvanN7 RazvanN7 merged commit 1ece3ea into dlang:master Dec 4, 2021
@RazvanN7
Copy link
Contributor

RazvanN7 commented Dec 4, 2021

Thanks @12345swordy for following through with this!

As a side note, you can push directly to an open PR to not go through the hurdle of opening a new one: https://ardupilot.org/dev/docs/editing-prs.html

@12345swordy 12345swordy deleted the 17870 branch December 4, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants