Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 22668 - Don't error when a deprecated method overrides another one #13533

Merged
merged 1 commit into from Jan 14, 2022

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Jan 14, 2022

Because both declarations acknowledge that the declaration is deprecated.
This is especially important for libraries that provide a collection of
classes and want to deprecate certain method(s) throughout the entire
class hierarchy.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22668 normal Deprecation when a deprecated method overrides another deprecated method

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13533"

Because both declarations acknowledge that the declaration is deprecated.
This is especially important for libraries that provide a collection of
classes and want to deprecate certain method throughout the entire
class hierarchy.
@MoonlightSentinel MoonlightSentinel changed the title Fix 22668 - Don't errors when a deprecated method overrides another one Fix 22668 - Don't error when a deprecated method overrides another one Jan 14, 2022
@dlang-bot dlang-bot merged commit 8041bcd into dlang:master Jan 14, 2022
@MoonlightSentinel MoonlightSentinel deleted the deprecated-override branch January 15, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants