Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 22659 - Do not gag semantic errors from _d_array{,set}ctor #13555

Merged
merged 2 commits into from Jan 20, 2022

Conversation

teodutu
Copy link
Member

@teodutu teodutu commented Jan 20, 2022

The errors in issue 22659 were caused by gagging errors from lowering to _d_array{,set}ctor in semantic3: #13476.

This PR fixes the issue above by removing the gagging altogether, albeit displaying some errors that mention _d_array{,set}ctor.

Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @teodutu! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22659 regression [REG master] Error: declaration '(S[2] arr = __error__;)' is not yet implemented in CTFE

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13555"

@dlang-bot dlang-bot merged commit 72cdd17 into dlang:master Jan 20, 2022
@teodutu teodutu deleted the fix-22659 branch May 21, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants