Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 22139 - Compiler special cases object.dup when compiling with -preview=dip1000 #13571

Merged
merged 1 commit into from Jan 28, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jan 25, 2022

Let's see if we can remove it now #12890 is merged

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22139 normal Compiler special cases object.dup when compiling with -preview=dip1000

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13571"

@thewilsonator thewilsonator added the 72h no objection -> merge The PR will be merged if there are no objections raised. label Jan 26, 2022
@thewilsonator thewilsonator added auto-merge and removed 72h no objection -> merge The PR will be merged if there are no objections raised. labels Jan 28, 2022
@dlang-bot dlang-bot merged commit 3a63145 into dlang:master Jan 28, 2022
@dkorpel dkorpel deleted the dup-special-case branch April 6, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants