Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 22714 - ICE: Assertion failure in ClassDeclaration::isBaseOf #13588

Merged
merged 1 commit into from Jan 31, 2022
Merged

fix Issue 22714 - ICE: Assertion failure in ClassDeclaration::isBaseOf #13588

merged 1 commit into from Jan 31, 2022

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jan 30, 2022

Introduced by change in master (not in stable).

@ibuclaw ibuclaw added Regression PRs that fix regressions Easy Review labels Jan 30, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 22714 regression ICE: Assertion failure in ClassDeclaration::isBaseOf

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13588"

@dlang-bot dlang-bot merged commit 5436d4d into dlang:master Jan 31, 2022
@ibuclaw ibuclaw deleted the regbaseof branch January 31, 2022 07:06
@tom-tan
Copy link
Contributor

tom-tan commented Mar 18, 2022

It introduced regression.
https://issues.dlang.org/show_bug.cgi?id=22859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinke kinke kinke approved these changes

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
auto-merge Bug Fix Easy Review Regression PRs that fix regressions
Projects
None yet
Milestone
No milestone
5 participants
@ibuclaw @dlang-bot @tom-tan @kinke @thewilsonator