New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Issue 22727 ImportC: add __stdcall Windows calling convention #13614
Conversation
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13614" |
e6c60d1
to
2290066
Compare
buildkite dmd/druntime fails with:
of which no illumination is given in the voluminous log file. It's likely a heisenbug, as this change has nothing to do with druntime. The log file is also full of exceptions and other faults, that seem to be ignored. |
There was one about __xopsuchandsuch that I'm pretty sure could be related to that. |
If in doubt, rebase local branch on current head. Likely just mismatching runtime and compiler (which wouldn't happen if they were in the same repo). |
@ibuclaw thanks, trying that. Why is buildkite retesting druntime anyway? Aren't all the endless other builds doing that enough? |
…cessary for 32-bit Windows builds
Would it be building it via dub? Just hazarding a guess though. |
Works same as
extern (Windows)
in D.This is a partial fix for https://issues.dlang.org/show_bug.cgi?id=22727 in that it does not implement
__fastcall
. There are no plans to implement__fastcall
.__stdcall
is poorly documented by Microsoft. Figuring out where it can appear in the grammar is the result of trial and error.