fix Issue 22590 - importC: static functions have no debug information…

[WalterBright]

… generated for them

Let's see if this works.

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	22590	normal	importC: static functions have no debug information generated for them

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13640"

[thewilsonator]

test?

[ibuclaw]

I pretty much dictated the fix in the issue, so I know that this will make debug generation work for static functions.

But why?

[WalterBright]

The SDsym is set when functions are placed in COMDATs. But static symbols are not in COMDATs.

[WalterBright]

@thewilsonator we don't have a good way to test debug info generation.

[RazvanN7]

@thewilsonator historically, PRs that fixed debug info issues were not required any tests. Although, a fail compilation tests which ends up in a SEGV for which the output is checked by a bash script wouldn't be too difficult to add.

[MoonlightSentinel]

@thewilsonator historically, PRs that fixed debug info issues were not required any tests. Although, a fail compilation tests which ends up in a SEGV for which the output is checked by a bash script wouldn't be too difficult to add.

False. The test runner explicitly supports GDB_SCRIPT for that purpose.

See e.g. https://github.com/dlang/dmd/blob/f0d454a3dadeb70a51e780705126e49258c815fc/test/runnable/gdb4149.d

[WalterBright]

@MoonlightSentinel great! Can you show how to make one for this?

[MoonlightSentinel]

A small example:

/// runnable/debuginfo.c
/*
REQUIRED_ARGS: -g
PERMUTE_ARGS:
GDB_SCRIPT:
---
run
---
GDB_MATCH: \*ptr = 1
*/

static
void foo(int* ptr)
{
    *ptr = 1;
}

int main(int argc, char** argv)
{
    foo(0);
    return 0;
}

GDB will print the line number + *ptr = 1 when foo isn't marked as static.

[maxhaton]

@WalterBright #13081 is another small example

[WalterBright]

@MoonlightSentinel thanks I added your example as a test.