Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create isUnaExp(), isBinExp(), isBinAssignExp() #13656

Merged
merged 1 commit into from Feb 15, 2022

Conversation

WalterBright
Copy link
Member

Use flags instead of inheritance/casting to determine these categories.

@WalterBright WalterBright added the Refactoring No semantic changes to code label Feb 15, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13656"

@WalterBright
Copy link
Member Author

dscanner is complaining about:

/var/lib/buildkite-agent/builds/ci-agent-59bf1ce0-2222-401d-afec-f34be92c8925-4/dlang/dmd/dmd/src/dmd/expression.d(7086:14)[warn]: This enum may lead to unnecessary allocation at run-time. Use 'static immutable Eunary = [ ...' instead.

but backend/oper.d does the same thing. How do I disable that style check?

@WalterBright
Copy link
Member Author

I found it. Never mind.

@dlang-bot dlang-bot merged commit 17df5e0 into dlang:master Feb 15, 2022
@WalterBright WalterBright deleted the EXPFLAGS branch February 15, 2022 07:11
@ibuclaw
Copy link
Member

ibuclaw commented Feb 18, 2022

This PR introduced a regression https://issues.dlang.org/show_bug.cgi?id=22788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Refactoring No semantic changes to code
Projects
None yet
4 participants