Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 22776 - string literal printing fails on non-ASCII/non-printable chars #13662

Merged
merged 1 commit into from Feb 16, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Feb 15, 2022

The logic of formatting characters is duplicated many times, so I extracted it to a separate function.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22776 normal string literal printing fails on non-ASCII/non-printable chars

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13662"

@dkorpel dkorpel marked this pull request as ready for review February 15, 2022 21:09
* c = code point to write
*/
nothrow
void writeCharLiteral(ref OutBuffer buf, dchar c)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth making sure this gets inlined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this performance critical, and is there a reason to distrust the compiler's judgement on whether to inline this function?

@dlang-bot dlang-bot merged commit d36b89c into dlang:master Feb 16, 2022
@dkorpel dkorpel deleted the string-literal-print branch March 24, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants