Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 22816 - [REG 2.099] Parser reads files with other extensions #13707

Merged
merged 1 commit into from Feb 23, 2022

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Feb 23, 2022

I can't see any rationale for this looking up filenames with different extensions. Either Module.read or the driver already ensures that the filename already has an inferred extension for all file arguments from the command-line.

All other uses of FileManager.lookup in dmd.error and dmd.expressionsem will also either have a file extension or have been checked that it exists on disk before calling.

No idea how to test this - I guess using dshell? It's important not to delay getting this in though, as it should not hit a release.

@ibuclaw ibuclaw added Regression PRs that fix regressions Bug Fix labels Feb 23, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
22816 regression [REG 2.099] Parser reads files with other extensions

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#13707"

@ibuclaw
Copy link
Member Author

ibuclaw commented Feb 23, 2022

FYI @hatf0

@MoonlightSentinel
Copy link
Contributor

MoonlightSentinel commented Feb 23, 2022

No idea how to test this - I guess using dshell?

Create fail_compilation/extra-files/foo.c + a fail_compilation test with EXTRA_SOURCES: extra-files/foo.d ?

@ibuclaw
Copy link
Member Author

ibuclaw commented Feb 23, 2022

No idea how to test this - I guess using dshell?

Create fail_compilation/extra-files/foo.c + a fail_compilation test with EXTRA_SOURCES: extra-files/foo.d ?

That's not really friendly with the dejagnu scripts, which expect these test directives to be pointing to files that exist. ;-)

@dlang-bot dlang-bot merged commit a04cb14 into dlang:stable Feb 23, 2022
@ibuclaw ibuclaw deleted the issue22816 branch February 23, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Bug Fix Regression PRs that fix regressions
Projects
None yet
4 participants