Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dshell tests for Issue 22816 and Issue 22817 #13713

Merged
merged 2 commits into from Feb 24, 2022

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Feb 23, 2022

@MoonlightSentinel - Eventually worked out how to make it work.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
22816 regression [REG 2.099] Parser reads files with other extensions

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#13713"

@ibuclaw ibuclaw force-pushed the issue22816tests branch 2 times, most recently from 68b3787 to b7e21f0 Compare February 23, 2022 18:30
@thewilsonator
Copy link
Contributor

Seems to fail on Windows, possibly due to / vs \?

@ibuclaw
Copy link
Member Author

ibuclaw commented Feb 24, 2022

Seems to fail on Windows, possibly due to / vs \?

That's what I thought, which is why I added .replace("/", SEP), and yet it still seems to fail.

@MoonlightSentinel
Copy link
Contributor

grep interprets the arguments as a regex. I've added a small commit that works on windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants