Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand fix for issue 22070 to also allow array literals as lvalues #14028

Merged
merged 1 commit into from Apr 27, 2022

Conversation

Yoplitein
Copy link
Contributor

Additionally checks for and restricts nested address-of expressions on string/array literals, such as &(&"")

This depends on #14027, test failures are expected for now.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Yoplitein! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22070 major importC: Error: string/array literal is not an lvalue

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14028"

@thewilsonator
Copy link
Contributor

please rebase.

Check for and restrict nested address-of expressions on literals, such as `&(&"")`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants