Bump default FreeBSD version to 12.x

[ibuclaw]

FreeBSD 11 has been retired from the main pkg repositories (https://pkg.freebsd.org/).

[dlang-bot]

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14069"

[kinke]

Argh. So autotester apparently uses v11 and needs an explicit flag.

[kinke]

Oh and DMD v2.079 apparently doesn't work on FreeBSD 12, producing a crashing build.d executable. Maybe use GDC for the FreeBSD bootstrapping job instead?

[ljmf00]

Oh and DMD v2.079 apparently doesn't work on FreeBSD 12, producing a crashing build.d executable. Maybe use GDC for the FreeBSD bootstrapping job instead?

Perhaps a problem on 12.3? We switched from 12.2 to 12.3 and only tested 12.3 when bootstrapping. Just a thought tho since it could be an old bug in the bootstrapping version.

[kinke]

Where are these actually used? I grepped for TARGET_FREEBSD in dmd/druntime/Phobos, no relevant hits.

[ljmf00]

I belive its just for future convenience, but yeah, probably worth to be on the build system itself rather than the CI config

[ibuclaw]

Apparently someone removed the code that used this version condition.

[ibuclaw]

This probably also means that the current 12.x pipeline is likely a sham, as the built compiler would be default targetting FreeBSD 11 if this is ignored.

[kinke]

Uh yeah probably. - This probably fell under the carpet with -target=… cross-compilation support. CI_DFLAGS are most likely not sufficient in that case (only affecting dmd/druntime/Phobos builds, not the default target of the built DMD).

[ljmf00]

That's correct. git log --pickaxe-regex tells me ee446a0 from #12508 .

[ljmf00]

Cross referencing #14071

[ibuclaw]

We'll bump the image post-release.

As the auto-tester is still using FreeBSD 11, it's not going to work to bump the default in dmd's code. Better off reviving the TARGET_FREEBSD version and using that in the Cirrus-CI pipelines.