fix Issue 23087 - getLinkage trait regression for overloads with v2.100.0-rc.1 #14072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuclaw
added
Bug Fix
Easy Review
Industry
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#14072" |
|
oh dmd how i love you |
adamdruppe
approved these changes
May 4, 2022
dkorpel
approved these changes
May 4, 2022
RazvanN7
approved these changes
May 4, 2022
kinke
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #13942, function linkages are not resolved early, and the use of
getOverloadsas per this test creates a new FuncAliasDeclaration for the__ctoroverload, which leaves the linkage unset. RunningfunctionSemanticon the alias doesn't set the linkage either, because _scope is null for function aliases as well.There's two ways to possibly go about this:
FuncDeclarationtoFuncAliasDeclarationimmediately after new'ing it.FuncDeclarationfrom this alias at the point of reading the linkage.This patch does the latter (2).