Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 23042 - -betterC still includes RTInfo #14078

Merged
merged 1 commit into from May 6, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented May 5, 2022

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23042 minor -betterC still includes RTInfo

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14078"

@dkorpel dkorpel marked this pull request as ready for review May 5, 2022 18:01
@rikkimax
Copy link
Contributor

rikkimax commented May 5, 2022

CI will need to be rerun due to a fix for FreeBSD #14076

@rikkimax
Copy link
Contributor

rikkimax commented May 6, 2022

Auto tester failing due to Darwin_64_64, not unique to this PR.

Test 'fail_compilation/test23037.c' failed. The logged output:
/Users/braddr/sandbox/at-client/pull-5190954-Darwin_64_64/dmd/generated/osx/release/64/dmd -conf= -m64 -Ifail_compilation -verrors=0 -fPIC -odgenerated/fail_compilation -ofgenerated/fail_compilation/test23037_0.o -c fail_compilation/test23037.c
fail_compilation/test23037.c(101): Error: type-specifier missing for declaration of a
fail_compilation/test23037.c(102): Error: type-specifier omitted for declaration of b
fail_compilation/test23037.c(103): Error: type-specifier is missing
fail_compilation/test23037.c(104): Error: type-specifier is missing
fail_compilation/test23037.c(105): Error: type-specifier is missing
fail_compilation/test23037.c(106): Error: type-specifier is missing
fail_compilation/test23037.c(201): Error: no type-specifier for parameter
fail_compilation/test23037.c(202): Error: no type-specifier for struct member
fail_compilation/test23037.c(203): Error: type-specifier omitted before declaration of x
fail_compilation/test23037.c(204): Error: type-specifier omitted for parameter x
fail_compilation/test23037.c(205): Error: type-specifier omitted before bit field declaration of x
fail_compilation/test23037.c(206): Error: no type-specifier for declarator
fail_compilation/test23037.c(207): Error: no type-specifier for declarator
fail_compilation/test23037.c(207): Error: found ; when expecting )
fail_compilation/test23037.c(209): Error: =, ; or , expected to end declaration instead of End of File

@RazvanN7
Copy link
Contributor

RazvanN7 commented May 6, 2022

Rebased to fix the FreeBSD failure.

@dlang-bot dlang-bot merged commit 74bf4d3 into dlang:master May 6, 2022
@dkorpel dkorpel deleted the betterc-rtinfo branch May 6, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants