New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImportC add Windows cl preprocessor #define support #14151
Conversation
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14151" |
33292cc
to
aa71fbf
Compare
How does that testdefine.c actually test the translation? Wouldn't the preprocessor just change that static assert to 3 == 3 without confirming the symbol is seen by D? |
aa71fbf
to
3531198
Compare
cool |
It sure would be nice if |
3531198
to
8eacc9c
Compare
The code is actually working, the errors are of the form:
i.e. |
346444d
to
cc12cfc
Compare
I'm lost. I don't know where Can anyone with a post-2020 |
What is exactly preventing you from installing the latest VC Walter? |
cbf3434
to
a922e44
Compare
a1bd9f8
to
5aad50b
Compare
943eb25
to
9ecd9f0
Compare
I found the problem. Thanks @rainers for your help! It's working now, except for some strange problem with the auto-tester that seems completely unrelated. |
@WalterBright There were some tabs introduced in #14153. But that was fixed by: #14154 . I rebased this PR and everything should be ok now. |
Trying it out with Microsoft's preprocessor