Fix Issues 23130, 19528 : Inline asm was too liberal about operand si… #14152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @maxhaton! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#14152" |
thewilsonator
approved these changes
May 21, 2022
|
Stable? |
|
I can but the bug was probably misfiled. |
…zes. A 8-byte type was only considered 8 bytes in 64 bit code, for some reason. This led to inconsistent compilation of extended asm. I tried to add an error message suggesting the use of an instruction like movsx but this code is spaghetti.
OK, master is fine if it is easier to get green. |
|
this breaks -m32 LEA and when performed on values with size > 4. This case should be supported as |
ljmf00
reviewed
May 21, 2022
Let me take a look. |
|
@maxhaton any progress on this? |
|
@maxhaton still pursuing or close? |
|
Still pursuing at some point although set back by the amount of work that
needs doing to it overall
…On Sun, 15 Jan 2023, 15:02 Iain Buclaw, ***@***.***> wrote:
@maxhaton <https://github.com/maxhaton> still pursuing or close?
—
Reply to this email directly, view it on GitHub
<#14152 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLI75HRQEMZR5RS6KPTL3TWSQGQFANCNFSM5WQ76CBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@maxhaton is this still on your radar? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…zes.
A 8-byte type was only considered 8 bytes in 64 bit code, for some reason.
This led to inconsistent compilation of extended asm.
I tried to add an error message suggesting the use of an instruction like movsx
but this code is spaghetti.