Issue 9230 - Incorrect implicit immutable conversion occurs in pure function #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re function `hasMutableIndirectionParams()` is based on the old `TypeFunction::purityLevel()` (before fixing issue 8408). So its result is consistent with `TypeFunction::purityLevel() != PUREstrong` in 2.060. Then it *fixes* the regression.
| * FIXME: This function is a workaround for fixing Bugzilla 9210. | ||
| * In 2.061, TypeFunction::purityLevel() improved to make more functions | ||
| * strong purity, but immutable conversion on return statemet had broken by that. | ||
| * Because, it is essentially unrelated to PUREstring. This function is |
Also updated test cases. By a recent change in 2.061 (4b2767e), direct returning of NewExp sometimes avoids immutable implicit conversion. So, test5081 should return mutable array values through local variables.
|
Updated. |
WalterBright
added a commit
that referenced
this pull request
Dec 28, 2012
Issue 9230 - Incorrect implicit immutable conversion occurs in pure function
WalterBright
added a commit
that referenced
this pull request
Dec 28, 2012
Issue 9230 - Incorrect implicit immutable conversion occurs in pure function
9rnsr
added a commit
to 9rnsr/dmd
that referenced
this pull request
Feb 5, 2013
- Revert "Merge pull request dlang#1418 from 9rnsr/fix9230" This reverts commit c42d35b, reversing changes made to 9f2d9ea. - Revert "Merge pull request dlang#1110 from 9rnsr/fix8408" This reverts commit b6a8093, reversing changes made to 3b06132.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=9230
hasMutableIndirectionParams()is based on the oldTypeFunction::purityLevel()(before fixing issue 8408). So its result is consistent withTypeFunction::purityLevel() != PUREstrongin 2.060. Then it fixes the regression.