Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix Issue 23177 - ModuleInfo is not exported on Windows" #14206

Merged
merged 3 commits into from Jun 13, 2022

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Jun 12, 2022

Reverts #14200.

With that change, not only will people see an extra MS linker line for every single linked D binary, but more importantly, linking a foo.exe leads to a potentially existing foo.lib to be overwritten by the import lib for that executable. So that can break builds and should have never landed in stable.

At the very least, the export should be explicitly enabled (after all, no existing and currently working code needs the exports). As DMD doesn't have an -fvisibility=public option yet (that's when LDC exports them), I'd say exporting with -shared only is an option for now. Then as good as all previous test adaptions can be gotten rid of again (e.g., the _dep filename changes) .

…error with Unicode symbol names"

This reverts commit ea3ebd6.
…t files generation message which causes failures when generated."

This reverts commit a848e70.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23177 blocker ModuleInfo is not exported on Windows

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14206"

@rikkimax
Copy link
Contributor

This should be merged, because I am indeed out of my depth on some of the issues being raised. I'll leave my branch so that it can hopefully be a starting point for someone else to fix these issues.

@kinke
Copy link
Contributor Author

kinke commented Jun 12, 2022

[dummy-amended for proper CI retriggering]

@Geod24 Geod24 merged commit 4ee3ac4 into dlang:stable Jun 13, 2022
@kinke kinke deleted the revert-14200-fix23177 branch June 13, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants