Revert "Fix Issue 23177 - ModuleInfo is not exported on Windows" #14206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14200.
With that change, not only will people see an extra MS linker line for every single linked D binary, but more importantly, linking a
foo.exe
leads to a potentially existingfoo.lib
to be overwritten by the import lib for that executable. So that can break builds and should have never landed instable
.At the very least, the export should be explicitly enabled (after all, no existing and currently working code needs the exports). As DMD doesn't have an
-fvisibility=public
option yet (that's when LDC exports them), I'd say exporting with-shared
only is an option for now. Then as good as all previous test adaptions can be gotten rid of again (e.g., the_dep
filename changes) .