fix Issue 22680 - @safe hole with destructors #14402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14402" |
|
This is blocked by dlang/phobos#8551 which is blocked by master not working. |
WalterBright
force-pushed
the
fix22680
branch
from
0d49867
to
6f53939
Compare
WalterBright
force-pushed
the
fix22680
branch
4 times, most recently
from
596014b
to
8b3166f
Compare
WalterBright
force-pushed
the
fix22680
branch
from
8b3166f
to
4780bae
Compare
RazvanN7
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying this out.
Made it only for class destructors, not struct destructors, because struct
thisis passed by ref, not by pointer.