Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 15414 - __traits(getAttributes) should error if the functio… #14554

Merged
merged 1 commit into from Nov 28, 2022

Conversation

RazvanN7
Copy link
Contributor

…n has multiple overloads

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
15414 normal __traits(getAttributes) should error if the function has multiple overloads

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14554"

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the release notes, appreciated 👍

changelog/dmd.deprecate-getAttributes-overloadSet.dd Outdated Show resolved Hide resolved
@RazvanN7
Copy link
Contributor Author

@Geod24 Thanks!

@thewilsonator Done.

@Geod24
Copy link
Member

Geod24 commented Oct 13, 2022

@RazvanN7
Copy link
Contributor Author

@Geod24 I tracked down the issue: dlang/phobos#8631

@RazvanN7 RazvanN7 closed this Nov 28, 2022
@RazvanN7 RazvanN7 reopened this Nov 28, 2022
@RazvanN7
Copy link
Contributor Author

All green. Merging.

@RazvanN7 RazvanN7 merged commit a90ed72 into dlang:master Nov 28, 2022
@JohanEngelen
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants