xtest46: Don't use overlapping array operation. #1470
Conversation
|
I don't see the problem here. Overlapping array ops is only a problem if they are being written to. This is not the case here. |
|
@WalterBright: Then druntime must be fixed. The test is actually failing against a non-release runtime, so there is definitely a problem here. |
|
@WalterBright: When you look at rt.{arrayfloat, arrayint, arraydouble}, you'll find that pretty much all of the binary operations have a |
In this specific case, there is little reason for it not to work, but druntime checks for overlapping operands in its in contract anyway. Fixes the test suite build in debug mode.
|
Ping? Allowing overlapping operands for non-critical cases would certainly be a sensible improvement, but the current druntime implementation doesn't accept them. The only reason the test suite passes for DMD is that it is never run against a non-release build of druntime. Opening an enhancement request at Bugzilla is certainly a much better way of making sure this doesn't get lost than keeping a broken test around. |
|
Makes sense. Please open a bugzilla issue for allowing overlapping array op inputs. |
xtestt46: Don't use overlapping array operation.
In this specific case, there is little reason for it not to work,
but druntime checks for overlapping operands in its in contract
anyway as they are generally not allowed for array ops.
Fixes the test suite build in debug mode – we should think about
running non-release builds regularly as part of the auto-tester.