Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 23218 - cgxmm.d:1373 assert fail #14790

Merged
merged 1 commit into from Jan 13, 2023
Merged

Conversation

WalterBright
Copy link
Member

This was actually two bugs:

  1. the vecfill problem outlined in the bug report
  2. a type paint was being used where a cast should have been

Also adjusted the strings emitted by the debug output so they matched SIMD types.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 8, 2023

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
23218 major ICE: src/dmd/backend/cgxmm.d:1373: Assertion `0' failed.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14790"

@ibuclaw
Copy link
Member

ibuclaw commented Jan 8, 2023

Should target stable.

@WalterBright
Copy link
Member Author

@RazvanN7 this only fixes 23218, not all those other issues.

@RazvanN7
Copy link
Contributor

@WalterBright I rebased this on stable for you, but you probably pushed from your master branch.

@dkorpel dkorpel force-pushed the fix23218 branch 2 times, most recently from 3278419 to 084efd5 Compare January 13, 2023 17:01
@dkorpel dkorpel merged commit c1f39e0 into dlang:stable Jan 13, 2023
@WalterBright WalterBright deleted the fix23218 branch January 13, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants