Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 23732 - Cannot create shared instance of class with -preview=nosharedaccess #14909

Merged
merged 1 commit into from Feb 26, 2023

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Feb 24, 2023

Revival of #14884 . cc @dkorpel @atilaneves

Also cc @Geod24 as it touches on code that you have added/modified.

I had to refactor a bit the dotvarexp code, but that is needed for this PR and it also makes the code clearer.

@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 24, 2023

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23732 regression Cannot create shared instance of class with -preview=nosharedaccess

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14909"

@RazvanN7 RazvanN7 force-pushed the Issue_23732 branch 2 times, most recently from 5cb1a15 to f036928 Compare February 24, 2023 11:28
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate the Expressions* -> ArgumentList into a separate commit or PR

@RazvanN7
Copy link
Contributor Author

ah damn, that's a rebase screw up

@RazvanN7 RazvanN7 changed the base branch from master to stable February 24, 2023 11:55
@dlang-bot dlang-bot merged commit c129fd0 into dlang:stable Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants