Refactor semanticTiargs() and fix Issue 9178 - UDA: getAttributes does not play well with tupleof #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardize processing of tiarg - type, symbol, and expression.
WalterBright
added a commit
that referenced
this pull request
Jan 19, 2013
Refactor semanticTiargs() and fix Issue 9178 - UDA: getAttributes does not play well with tupleof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=9178
In
TemplateInstance::semanticTiargs, all template arguments should be processed by a consistent way. But its implementation is a little dirty.9178 is a bug which was leaked from the fix for 9100 (== #1340), which implicitly had caused by it.
This refactoring cleans the code, and get a bug fix as a side-effect.