New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 22765 - Assertion failure in CppMangleVisitor.template_args #15100
Conversation
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#15100" |
/* | ||
TEST_OUTPUT: | ||
--- | ||
fail_compilation/test22765.d(14): Error: template instance `test22765.Template!null` internal compiler error: C++ `null` template value parameter is not supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internal compiler errors should never be reachable, so this PR introduced a regression.
This PR introduced a regression https://issues.dlang.org/show_bug.cgi?id=23878 |
It's not a regression when it used to be worse (an assertion failure). Note the PR description:
|
The current understanding is that the fix should be elsewhere during semantic, not when we're generating the mangling after the point it should have been caught. An ICE is still an ICE, so this test has to be thrown out until a proper fix is done.
|
Replace assert with an error message.
The error looks weird, but I just followed the pattern already present. Rewording the error should be the subject of a different PR.