Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 23402 - importc function definitions from includes can caus… #15101

Merged
merged 1 commit into from Apr 13, 2023
Merged

fix Issue 23402 - importc function definitions from includes can caus… #15101

merged 1 commit into from Apr 13, 2023

Conversation

WalterBright
Copy link
Member

…e D name conflicts

@WalterBright WalterBright added Easy Review ImportC Pertaining to ImportC support labels Apr 13, 2023
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 23402 normal importc function definitions from includes can cause D name conflicts

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15101"

@WalterBright WalterBright force-pushed the fix23402 branch 2 times, most recently from 3b20050 to 4941cac Compare April 13, 2023 03:26
@WalterBright
Copy link
Member Author

Ready to merge.

@PetarKirov
Copy link
Member

@adamdruppe perhaps you want to try this change in a more real world setting.

@WalterBright WalterBright merged commit 6f9d321 into dlang:master Apr 13, 2023
41 of 44 checks passed
@WalterBright WalterBright deleted the fix23402 branch April 13, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkorpel dkorpel dkorpel approved these changes

Assignees
No one assigned
Labels
Bug Fix Easy Review ImportC Pertaining to ImportC support
Projects
ImportC
Status: Done
Milestone
No milestone
4 participants
@WalterBright @dlang-bot @PetarKirov @dkorpel