Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable code coverage test for circleCI #15128

Merged
merged 1 commit into from Apr 25, 2023

Conversation

RazvanN7
Copy link
Contributor

:shipit:

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15128"

@RazvanN7
Copy link
Contributor Author

cc @dkorpel

@PetarKirov
Copy link
Member

PetarKirov commented Apr 25, 2023

CircleCI is finally green 🎉
Only macOS and GDC left to go fully green!
@RazvanN7 go ahead and merge manually and please open a Bugzilla ticket as a reminder to fix the codecov issue eventually.

@RazvanN7 RazvanN7 merged commit 63aa219 into dlang:master Apr 25, 2023
40 of 44 checks passed
@RazvanN7
Copy link
Contributor Author

https://issues.dlang.org/show_bug.cgi?id=23860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants