Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 23846 - Respect the C standard when it comes to string to f… #15139

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Fix Issue 23846 - Respect the C standard when it comes to string to f… #15139

merged 3 commits into from
Apr 28, 2023

Conversation

maxhaton
Copy link
Member

…loat ERRNO and return value

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @maxhaton!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 23846 major std.math can't compile under macos rosetta

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15139"

@maxhaton
Copy link
Member Author

Let's find out if it works

kinke
kinke reviewed Apr 27, 2023
View reviewed changes
compiler/src/dmd/root/port.d Outdated Show resolved Hide resolved
@kinke
Copy link
Contributor

kinke commented Apr 27, 2023

And do you have a link handy wrt. the standard? As it seems like only Apple chose to break this recently.

@maxhaton @dkorpel
Update compiler/src/dmd/root/port.d
da02b1c 
Co-authored-by: Dennis <dkorpel@users.noreply.github.com>
@dkorpel
Copy link
Contributor

dkorpel commented Apr 28, 2023

CircleCI failure is now because of #15141

@RazvanN7
Copy link
Contributor

@maxhaton please address the reviews and let's get this in! MacOS finally green 🎉

@RazvanN7
Copy link
Contributor

@kinke All ok with this PR?

@dlang-bot dlang-bot merged commit deaf1b8 into dlang:master Apr 28, 2023
@dkorpel
Copy link
Contributor

dkorpel commented Apr 28, 2023

Thanks Max!

@PetarKirov PetarKirov mentioned this pull request Feb 13, 2024
Closed
PetarKirov added a commit to PetarKirov/dlang.nix that referenced this pull request Feb 18, 2024
@PetarKirov
fix(pkgs/dmd/{v2.102.2..v2.104.0): Add patch to enable x86_64-darwin …
d14624c 
…compilation

See:
* https://issues.dlang.org/show_bug.cgi?id=23846
* dlang/dmd#15139
PetarKirov added a commit to PetarKirov/dlang.nix that referenced this pull request Feb 18, 2024
@PetarKirov
fix(pkgs/dmd/{v2.102.2..v2.104.0): Add patch to enable x86_64-darwin …
ab36881 
…compilation

See:
* https://issues.dlang.org/show_bug.cgi?id=23846
* dlang/dmd#15139
PetarKirov added a commit to PetarKirov/dlang.nix that referenced this pull request Feb 18, 2024
@PetarKirov
fix(pkgs/dmd/{v2.102.2..v2.104.0): Add patch to enable x86_64-darwin …
50062d0 
…compilation

See:
* https://issues.dlang.org/show_bug.cgi?id=23846
* dlang/dmd#15139
PetarKirov added a commit to PetarKirov/dlang.nix that referenced this pull request Feb 18, 2024
@PetarKirov
fix(pkgs/dmd/{v2.102.2..v2.104.0): Add patch to enable x86_64-darwin …
9a750cd 
…compilation

See:
* https://issues.dlang.org/show_bug.cgi?id=23846
* dlang/dmd#15139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinke kinke kinke left review comments

@dkorpel dkorpel dkorpel left review comments

@atilaneves atilaneves atilaneves approved these changes

Assignees
No one assigned
Labels
auto-merge Bug Fix
Projects
None yet
Milestone
No milestone
6 participants
@maxhaton @dlang-bot @kinke @dkorpel @RazvanN7 @atilaneves