Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 23875 23880 #15172

Merged
merged 1 commit into from May 5, 2023
Merged

fix Issue 23875 23880 #15172

merged 1 commit into from May 5, 2023

Conversation

WalterBright
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented May 3, 2023

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
23875 normal ImportC: __attribute__ in a cast doesn't work
23880 normal ImportC: __attribute__((vector_size(N))) is not implemented

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15172"

@WalterBright WalterBright changed the title fix Issue 23857 and fix Issue 23880 fix Issue 23857 23880 May 3, 2023
@WalterBright WalterBright changed the title fix Issue 23857 23880 fix Issue 23875 23880 May 3, 2023
@WalterBright WalterBright force-pushed the fix23875 branch 2 times, most recently from b5ac24f to 1f34cd0 Compare May 3, 2023 05:17
@ibuclaw
Copy link
Member

ibuclaw commented May 3, 2023

Bug fixes should target stable please.

@RazvanN7
Copy link
Contributor

RazvanN7 commented May 4, 2023

I fixed the conflict for you @WalterBright .

@ibuclaw we have been merging importC fixed in master up until now.

@RazvanN7 RazvanN7 merged commit c3a960d into dlang:master May 5, 2023
41 of 44 checks passed
@WalterBright WalterBright deleted the fix23875 branch May 5, 2023 07:59
@WalterBright
Copy link
Member Author

Thanks!

@dkorpel
Copy link
Contributor

dkorpel commented May 5, 2023

Why was this merged despite failing tests?

D:\a\1\s\generated\windows\release\32\dmd.exe -conf= -m32omf -Icompilable   -odD:\a\1\s\compiler\test\test_results\compilable -ofD:\a\1\s\compiler\test\test_results\compilable\stdcheaders_0.obj  -c compilable\stdcheaders.c 


D:\a\1\s\tools\dm\include\wchar.h(227): Error: unterminated string constant starting at #defines(778)

Edit: nevermind, Azure was green on this PR

@maxhaton
Copy link
Member

maxhaton commented May 5, 2023

Why was it green?

@dkorpel
Copy link
Contributor

dkorpel commented May 5, 2023

I don't know why it was green in this PR, after it was merged, it turned red: https://github.com/dlang/dmd/runs/13256496507

@maxhaton
Copy link
Member

maxhaton commented May 5, 2023 via email

dkorpel added a commit that referenced this pull request May 7, 2023
WalterBright pushed a commit that referenced this pull request May 7, 2023
WalterBright added a commit that referenced this pull request May 11, 2023
PetarKirov pushed a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants