Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 23882 - ICE (segfault) on nasty alias this code #15177

Merged
merged 1 commit into from May 5, 2023

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented May 4, 2023

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented May 4, 2023

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23882 regression ICE (segfault) on nasty alias this code

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#15177"

Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stable?

@RazvanN7 RazvanN7 changed the base branch from master to stable May 4, 2023 12:02
@RazvanN7
Copy link
Contributor Author

RazvanN7 commented May 4, 2023

Yeah, sorry, I did rebase on stable, just forgot to change the branch from the github interface.

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented May 4, 2023

forced push to restart the canceled CIs

@RazvanN7 RazvanN7 merged commit 9d5f960 into dlang:stable May 5, 2023
41 of 44 checks passed
@ibuclaw ibuclaw mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants