fix Issue 23928 - improve error msg: scope variable s assigned to non… #15249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#15249" |
…-scope parameter this calling abc
RazvanN7
approved these changes
May 19, 2023
PetarKirov
reviewed
May 19, 2023
| @@ -9,7 +9,7 @@ fail_compilation/test20245.d(27): Error: cannot take address of `scope` variable | |||
| fail_compilation/test20245.d(33): Error: reference to local variable `x` assigned to non-scope parameter `ptr` calling `escape` | |||
| fail_compilation/test20245.d(34): Error: copying `&x` into allocated memory escapes a reference to parameter `x` | |||
| fail_compilation/test20245.d(50): Error: reference to local variable `price` assigned to non-scope `this.minPrice` | |||
| fail_compilation/test20245.d(69): Error: reference to local variable `this` assigned to non-scope parameter `msg` calling `this` | |||
| fail_compilation/test20245.d(69): Error: reference to local variable `this` calling non-scope member function `this.this()` | |||
There was a problem hiding this comment.
This message is hard to understand as it makes no mention of types involved.
Perhaps something like this:
Suggested change
| fail_compilation/test20245.d(69): Error: reference to local variable `this` calling non-scope member function `this.this()` | |
| fail_compilation/test20245.d(69): Error: reference to member variable `DontDoThis.content` calling non-scope member function `Exception.this()` |
There was a problem hiding this comment.
This is a good suggestion, but the PR has been pulled. File a bugzilla for it?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-scope parameter this calling abc