Revert "Deprecate alias this for classes v2"

[WalterBright]

Reverts #14812

Well, that was a disaster. My fault.

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#15326"

[WalterBright]

I need to push a change to this PR. How do I do it? googling has failed me!

[WalterBright]

Here is my attempt to fix it:

git pull upstream revert-14812-deprecate_alias_this_for_classes
git checkout revert-14812-deprecate_alias_this_for_classes
cd compiler/src/dmd
edit dtoh.d
git status
git commit --amend -a --no-edit
git push -f origin revert-14812-deprecate_alias_this_for_classes

These commands succeeded, but where did my changes go? They're not here.

[RazvanN7]

What I typically do (assuming that you are now on master/main branch):

git fetch your_fork_name revert-14812
git checkout  revert-14812
... edit files ...
git add $(edited_files)
git commit -m "Revert alias this deprecation for classes"
git push -f your_fork_name revert-14812

[WalterBright]

What is my fork name?

[WalterBright]

This is the usual way I amend one of my pull requests:

git checkout revert-14812-deprecate_alias_this_for_classes
cd compiler/src/dmd
edit dtoh.d
git status
git commit --amend -a --no-edit
git push -f origin revert-14812-deprecate_alias_this_for_classes

Why did this not work in this case? Where did the git push send it? To purgatory?

[dkorpel]

These commands succeeded, but where did my changes go?

When you use the 'revert' button on GitHub, it creates a branch in the dlang/dmd repository. You pulled from this with git pull upstream, but you pushed to origin with git push -f origin, so it got sent to your WalterBright/dmd fork: https://github.com/WalterBright/dmd/tree/revert-14812-deprecate_alias_this_for_classes

[dkorpel]

Perhaps open a new pull request from your fork

[ErnyTech]

The deprecation of alias this for the class was a disaster mainly because there was no viable alternative.

I'm happy with this revert but I think it would be good later to think about how to solve the problems that were with alias this or provide an alternative feature

[WalterBright]

@dkorpel so I need to push it to upstream instead of origin?

[WalterBright]

Looks like pushing it to upstream worked

[WalterBright]

The test suite errors look irrelevant.

[dkorpel]

Now that stable is merged, no more spurious failures