Fix Issue 11612 - Inconsistent error on negative new array size #15359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#15359" |
RazvanN7
approved these changes
Jun 28, 2023
|
thanks! |
ibuclaw
reviewed
Jul 10, 2023
| @@ -4084,9 +4084,10 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor | |||
| if (arg.op == EXP.error) | |||
| return setError(); | |||
| arg = arg.optimize(WANTvalue); | |||
| if (arg.op == EXP.int64 && cast(sinteger_t)arg.toInteger() < 0) | |||
| if (arg.op == EXP.int64 && (target.is64bit ? | |||
There was a problem hiding this comment.
Why is a CPU-specific parameter being used in the front-end?
|
This PR caused a regression. |
ibuclaw
added a commit
to ibuclaw/dmd
that referenced
this pull request
Jul 10, 2023
dkorpel
pushed a commit
that referenced
this pull request
Jul 10, 2023
|
This PR caused a regression on all 32-bit pointer platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RazvanN7 This implements https://github.com/orgs/dlang/projects/9/views/1?pane=issue&itemId=10645447.