Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resurrect empty statement #15409

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

WalterBright
Copy link
Member

Empty statements seem harmless enough. Though things like:

if (i);
for (;;);

are still not allowed.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15409"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test cases?

@WalterBright
Copy link
Member Author

There should already be test cases in the test suite, which should now be failing.

@WalterBright
Copy link
Member Author

And there it is!

@WalterBright WalterBright merged commit b6a9706 into dlang:master Jul 13, 2023
43 of 44 checks passed
@WalterBright WalterBright deleted the emptyStatement branch July 13, 2023 15:47
ntrel added a commit to ntrel/dmd that referenced this pull request Apr 29, 2024
ntrel added a commit to ntrel/dmd that referenced this pull request Apr 29, 2024
dlang-bot pushed a commit that referenced this pull request Apr 29, 2024
kinke pushed a commit to ldc-developers/ldc that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants