Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 24056 - const uninitialized data at module scope is not in TLS #15458

Merged
merged 3 commits into from Jul 28, 2023

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jul 25, 2023

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24056 normal const uninitialized data at module scope is not in TLS

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15458"

@AndrejMitrovic
Copy link
Contributor

I thought it would make more sense to move const data to TLS. Only immutable is documented as shared by the spec as far as I know. @WalterBright what do you think about https://issues.dlang.org/show_bug.cgi?id=24056?

@dkorpel
Copy link
Contributor Author

dkorpel commented Jul 26, 2023

I thought it would make more sense to move const data to TLS.

That would break or subtly change the behavior of existing code.

@RazvanN7
Copy link
Contributor

Please add a changelog entry.

@dkorpel
Copy link
Contributor Author

dkorpel commented Jul 27, 2023

For a bug fix?

@RazvanN7
Copy link
Contributor

RazvanN7 commented Jul 27, 2023

For a deprecation. Code that used to compile will now issue a deprecation.

@dkorpel dkorpel merged commit c3d0b1f into dlang:master Jul 28, 2023
43 of 44 checks passed
@dkorpel dkorpel deleted the const-shared-sctor branch July 28, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants