Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSOptions: Prepare for setting the INCLUDE env var for importC #15780

Merged
merged 1 commit into from Nov 16, 2023

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Nov 7, 2023

Upstreaming from LDC, to pave the way for fixing Issue 24111.

Upstreaming from LDC, to pave the way for fixing Issue 24111.
@kinke kinke requested a review from ibuclaw as a code owner November 7, 2023 00:45
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24111 enhancement [ImportC] fatal error C1034: stdio.h: no include path set

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15780"

if (auto p = umExists(sdk, WindowsSdkVersion.toDString)) // SDK 10.0
return p;
}
// purely speculative
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any old SDKs on my box, so couldn't verify the subdirs for those.

@kinke
Copy link
Contributor Author

kinke commented Nov 7, 2023

See https://github.com/ldc-developers/ldc/blob/8399e47ceb4dfbbcf1ca0b7cf934c04a864387b7/driver/tool.cpp#L297-L312 for how these 2 functions are to be used as base for setting up INCLUDE.

@RazvanN7 RazvanN7 merged commit 4b508de into dlang:master Nov 16, 2023
43 checks passed
@kinke kinke deleted the vsoptions_include branch November 17, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants