-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move a couple of functions out of dsymbol.d #15789
Conversation
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#15789" |
Because it's needed for ModuleInfo runtime support! |
1eedd8e
to
ebdc12e
Compare
I moved it to |
extern bool builtinTypeInfo(Type* t);
+extern FuncDeclaration* findGetMembers(ScopeDsymbol* dsym);
+
class SemanticTimeTransitiveVisitor : public SemanticTimePermissiveVisitor
{
public: |
ebdc12e
to
35ca420
Compare
I'd tend to disagree - ModuleInfo != TypeInfo. |
This reverts commit 7bff453.
findGetMembers
is only used in toobj, but seems to be used from gdc so I didn't make it private.searchX
is only used in typesem.d