Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a couple of functions out of dsymbol.d #15789

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Nov 8, 2023

  • findGetMembers is only used in toobj, but seems to be used from gdc so I didn't make it private.
  • searchX is only used in typesem.d

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15789"

@ibuclaw
Copy link
Member

ibuclaw commented Nov 8, 2023

  • findGetMembers is only used in toobj, but seems to be used from gdc so I didn't make it private.

Because it's needed for ModuleInfo runtime support!

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Nov 9, 2023

I moved it to typinf.d . looks like the appropriate place to put it in.

@thewilsonator
Copy link
Contributor

frontend.h diff missing

 extern bool builtinTypeInfo(Type* t);
 
+extern FuncDeclaration* findGetMembers(ScopeDsymbol* dsym);
+
 class SemanticTimeTransitiveVisitor : public SemanticTimePermissiveVisitor
 {
 public:

@RazvanN7 RazvanN7 merged commit 7bff453 into dlang:master Nov 9, 2023
43 checks passed
@ibuclaw
Copy link
Member

ibuclaw commented Nov 12, 2023

I moved it to typinf.d . looks like the appropriate place to put it in.

I'd tend to disagree - ModuleInfo != TypeInfo.

ibuclaw added a commit that referenced this pull request Nov 12, 2023
ibuclaw added a commit to ibuclaw/dmd that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants