-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate _d_newarray{mTX, miTX, Op}
to a single template
#15819
Conversation
Thanks for your pull request, @teodutu! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#15819" |
6884ad9
to
a6e64d3
Compare
_d_newarray{mTX, miTX, Op}
to a single template_d_newarray{mTX, miTX, Op}
to a single template
a6e64d3
to
095f1ac
Compare
095f1ac
to
2cc7ed8
Compare
I'll improve the hook and its nested function in the coming days. Up to now, I just wanted something that works and hopefully passes the CI tests. |
84975ff
to
78e2c8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Looks like some profile gc tests need to be updated.
|
78bb38c
to
90dfb5b
Compare
@teodutu maybe also add a changelog entry to be consistent with the previously templated hook? |
693f694
to
c6122bf
Compare
- Move code for `_d_newarraymTX` to `core.internal.array.construction` - Remove `_d_newarraymiTX` and `_d_newarraymOp` - Add unittests for `_d_newarraymTX` - Move lowering to `_d_newarraymTX` to the semantic phase - Inline the lowering when inlining `NewExp`s - Add changelog entry about the new hook Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
c6122bf
to
e9d70fe
Compare
Done @RazvanN7. |
This caused a regression: https://issues.dlang.org/show_bug.cgi?id=24436 Since #16097 the regression does not happen any more for me. |
_d_newarraymTX
tocore.internal.array.construction
_d_newarraymiTX
and_d_newarraymOp
_d_newarraymTX
_d_newarraymTX
to the semantic phaseNewExp
s