fix Issue 24184 - [REG 2.103] Segmentation fault accessing variable w… #15820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#15820" |
ghost
reviewed
Nov 16, 2023
WalterBright
force-pushed
the
fix24184
branch
from
25d7b51
to
2de0cd2
Compare
|
Recent regression, that should go on stable. |
|
It's not really a regression, it never worked. |
|
Runtime corruption fixes still better in stable than waiting for the next release. |
…ith align(N) > platform stack alignment
RazvanN7
requested review from
MartinNowak,
wilzbach and
ibuclaw
as code owners
RazvanN7
approved these changes
Nov 16, 2023
|
Thanks @RazvanN7 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ith align(N) > platform stack alignment
Forgot to add an offset when the context pointer wasn't RPB.