Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 24309 - Memory allocation failed on Azure pipeline #15997

Merged
merged 1 commit into from Jan 4, 2024

Conversation

rainers
Copy link
Member

@rainers rainers commented Jan 4, 2024

only run GC test that requires 4 GB of memory if that's available as free physical memory

Please note that os_physical_mem() is only used by this test.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 4, 2024

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close Bugzilla Severity Description
24309 normal Memory allocation failed on Azure pipeline

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#15997"

@kinke
Copy link
Contributor

kinke commented Jan 4, 2024

Thx Rainer for investigating and trying to fix this sporadic issue. 👍

Targeting stable would be nice to improve the situation for just-initiated v2.107.

@rainers rainers changed the base branch from master to stable January 4, 2024 16:04
@rainers rainers requested a review from ibuclaw as a code owner January 4, 2024 16:04
only run GC test that requires 4 GB of memory if that's available as *free* physical memory
@rainers
Copy link
Member Author

rainers commented Jan 4, 2024

Targeting stable would be nice to improve the situation for just-initiated v2.107.

Ok, rebased. A merge back to master soon would be much appreciated :)

@dlang-bot dlang-bot merged commit e1d1512 into dlang:stable Jan 4, 2024
45 of 46 checks passed
@kinke
Copy link
Contributor

kinke commented Jan 4, 2024

@rainers
Copy link
Member Author

rainers commented Jan 5, 2024

Oh well, the problem still occurs,

Too bad. Maybe the VM is only a little above the necessary threshold, but cannot assign it to a single allocation. An option could be to add a few GB to it, or just disable the test.

@kinke
Copy link
Contributor

kinke commented Jan 5, 2024

I'm wondering why this was never an issue on Linux, as those runners have 7 GB RAM too. Maybe just vastly more efficient virtual mem allocation on Linux, hardly needing any physical page for that huge, as good as unused allocation?

@rainers
Copy link
Member Author

rainers commented Jan 5, 2024

Maybe just vastly more efficient virtual mem allocation on Linux, hardly needing any physical page for that huge, as good as unused allocation?

I guess it is something like that. Or the Linux VM allows swapping, but the Windows VM does not.

@WalterBright
Copy link
Member

Thanks everyone for working hard to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants