[REG master] Explicitly instantiate StringValue!Type in dmd.mtype #16138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
ibuclaw
added
Regression
ibuclaw
force-pushed
the
fix_build_reg
branch
from
1cb4284
to
ef76806
Compare
Issue 21299 has reared its ugly head again, this time the revert needed to resolve it is: ```diff --- a/compiler/src/dmd/dsymbolsem.d +++ b/compiler/src/dmd/dsymbolsem.d @@ -21,6 +21,7 @@ import dmd.arraytypes; import dmd.astcodegen; import dmd.astenums; import dmd.attrib; +import dmd.blockexit; import dmd.clone; import dmd.cond; import dmd.dcast; ``` These code migrations between modules are making the import graph extremely brittle for compilers with the known template emission bug, and the relation between the bug and the change that triggered it is becoming less obvious. In order to inure ourselves against these linker errors then, the `String!Value` type is now explicitly instantiated inside `dmd.mtype`. This is safe for compilers with and without the template issue, but it is put inside a `static if` block anyway to make it clear that it shouldn't be removed.
ibuclaw
force-pushed
the
fix_build_reg
branch
from
ef76806
to
af7bc99
Compare
thewilsonator
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous history: #11827 #11838 #15854 #15872 #15873
Issue 21299 has reared its ugly head again, this time the revert needed to resolve it is:
These code migrations between modules are making the import graph extremely brittle for compilers with the known template emission bug, and the relation between the bug and the change that triggered it is becoming less obvious.
In order to inure ourselves against these linker errors then, the
String!Valuetype is now explicitly instantiated insidedmd.mtype. This is safe for compilers with and without the template issue, but it is put inside astatic ifblock anyway to make it clear that it shouldn't be removed.