Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] GHA: Switch to old Xcode as workaround for macOS-13 jobs #16194

Merged
merged 1 commit into from Feb 20, 2024

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Feb 16, 2024

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 16, 2024

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#16194"

.github/workflows/main.yml Outdated Show resolved Hide resolved
@ibuclaw
Copy link
Member

ibuclaw commented Feb 16, 2024

At some point Xcode 14 will be unavailable, so this is just prolonging the inevitable - someone who is intimate with OSX and dmd back-end needs to:

  1. Fix this issue in the compiler.
  2. Fix all other issues targeting OSX whilst we're at it.
  3. Fix debugging on OSX (with lldb/gdb).

@kinke
Copy link
Contributor Author

kinke commented Feb 16, 2024

There's an extra disadvantage - this workaround would need to be duplicated in the Phobos YAML.

@kinke kinke marked this pull request as ready for review February 16, 2024 20:06
Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the very least target stable.

@kinke kinke changed the base branch from master to stable February 20, 2024 21:30
@kinke kinke changed the title GHA: Try switching to old Xcode for macOS-13 jobs [stable] GHA: Switch to old Xcode as workaround for macOS-13 jobs Feb 20, 2024
Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: if this gets fixed in dmd, then the host compiler will have to be swapped with ldc until enough time has passed that dmd can bootstrap itself again.

See: #13890

@ibuclaw ibuclaw merged commit 85b807c into dlang:stable Feb 20, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants