machobj: Rename align_ to p2align where its value is assumed as power of 2 #16220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuclaw
added
Refactoring
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16220" |
| @@ -2690,9 +2690,9 @@ int elf_align(targ_size_t size, int foffset) | |||
| @trusted | |||
| void MachObj_moduleinfo(Symbol *scc) | |||
| { | |||
| int align_ = I64 ? 3 : 2; // align to _tysize[TYnptr] | |||
| int p2align = I64 ? 3 : 2; // align to _tysize[TYnptr] | |||
There was a problem hiding this comment.
3 is not a power of 2...
There was a problem hiding this comment.
It is a power of 2 byte alignment. (i.e: .p2align 3 is 8 bytes).
|
It'll probably save some time if this waits until after the next stable->master merge, as it'll need to be rebased anyway. |
RazvanN7
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Machobj is the only backend that treats
align_as a "power of 2" rather than byte alignment, which seems to have tripped someone up before (see #16219). Renaming all uses of these to make it distinct from other variable/fields names that share the same name/purpose.