Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 24479 - [REG2.104] Error on getAttributes on getOverloads of templates #16358

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Apr 5, 2024

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 5, 2024

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24479 regression [REG2.104] Error on getAttributes on getOverloads of templates

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#16358"

@RazvanN7 RazvanN7 changed the base branch from master to stable April 5, 2024 12:51
@RazvanN7 RazvanN7 added Regression PRs that fix regressions Industry Applies to PRs pertaining to industry applications of D labels Apr 5, 2024
@@ -1244,7 +1244,7 @@ Expression semanticTraits(TraitsExp e, Scope* sc)
// @@@DEPRECATION 2.100.2
if (auto td = s.isTemplateDeclaration())
{
if (td.overnext || td.overroot)
if (td.overnext)
Copy link
Contributor Author

@RazvanN7 RazvanN7 Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out overroot is always set, even for individual template declarations.

@rikkimax
Copy link
Contributor

rikkimax commented Apr 5, 2024

std/internal/unicode_grapheme.d(375): Error: array cast from `string` to `immutable(ulong[])` is not supported at compile time

https://buildkite.com/dlang/dmd/builds/36046#018eae54-6bde-42b5-96db-3741b1aacb79

oo that's fun one, this is something @dkorpel did for last release.

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Apr 5, 2024

So I'm assuming stable hasn't got some patches that are required?

@RazvanN7
Copy link
Contributor Author

@dkorpel any hints on how the buildkite failure can be fixed?

@dkorpel
Copy link
Contributor

dkorpel commented Apr 16, 2024

Have you rebased this PR on the latest stable? The new hex string conversions should be in there.

@RazvanN7
Copy link
Contributor Author

I did now. I thought I had the latest version of stable, but it seems I didn't.

@thewilsonator thewilsonator merged commit 9ca4c29 into dlang:stable Apr 18, 2024
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Industry Applies to PRs pertaining to industry applications of D Regression PRs that fix regressions
Projects
Status: In Progress
6 participants