-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 24479 - [REG2.104] Error on getAttributes on getOverloads of templates #16358
Conversation
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#16358" |
@@ -1244,7 +1244,7 @@ Expression semanticTraits(TraitsExp e, Scope* sc) | |||
// @@@DEPRECATION 2.100.2 | |||
if (auto td = s.isTemplateDeclaration()) | |||
{ | |||
if (td.overnext || td.overroot) | |||
if (td.overnext) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out overroot
is always set, even for individual template declarations.
https://buildkite.com/dlang/dmd/builds/36046#018eae54-6bde-42b5-96db-3741b1aacb79 oo that's fun one, this is something @dkorpel did for last release. |
So I'm assuming stable hasn't got some patches that are required? |
@dkorpel any hints on how the buildkite failure can be fixed? |
Have you rebased this PR on the latest stable? The new hex string conversions should be in there. |
…erloads of templates
I did now. I thought I had the latest version of stable, but it seems I didn't. |
No description provided.