New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[foreach] Deprecate ref
for array index or ForeachRangeStatement
#16381
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16381" |
For some reason that didn't get picked up by dlang-bot. Edit: added a separate commit saying that, now it got picked up. Does it not find multiple issues? |
6f48624
to
7bfff75
Compare
Fix Bugzilla 24499 - foreach over a ref parameter to an rvalue should be an error Fix Bugzilla 24232 - ref for index of foreach for arrays is not allowed by spec but accepted by compiler
…ed by spec but accepted by compiler
I think it does when you list them like "Fix Bugzilla 24499, 24232" |
ref
for array index or range parameterref
for array index or ForeachRangeStatement
Fix Bugzilla 24499 - foreach over a ref parameter to an rvalue should be an error
Fix Bugzilla 24232 - ref for index of foreach for arrays is not allowed by spec but accepted by compiler