Add a mechanism for forcing codegen for an import/module. #16443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could very easily lead to duplicate symbols. All the symbols would need to have the appropriate linker flag(s) set to allow for duplicates. As-is this will result in our builds being more fragile than necessary. Some thinking about how to handle duplicates needs to take place before merging a solution to this. |
|
Closing this as I've realised a way to obviate the need for forcing module-wide codegen for #16372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism which lets the frontend indicate that codegen should always take place for an import/module, even if that module wasn't supplied on the command-line when the compiler was invoked, and regardless of whether the
-iswitch was supplied or not.My main motivation for this is for #16372; so that codegen can be forced for the
__builtins_msvcmodule, so that#include <importc_msvc_builtins.h>just works regardless of how the compiler was invoked. (Additional context: #16372 (comment); #16372 (comment); #16372 (comment))