-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitfields: add bitoffsetof, bitwidth, isBitfield #16444
Conversation
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16444" |
Awesome! Thanks for doing this, it'll be a real help. That covers one of the major issues I outlined in my original post. |
965de1c
to
e13d270
Compare
@jmdavis This should address the introspection concerns and help you with your work on traits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a changelog entry
7ed42ab
to
7872730
Compare
7872730
to
b5049f4
Compare
As for the "Needs Spec PR" there's a 2+ year old PR for bitfield documentation: |
You would still need to add those properties & trait to that PR |
@RazvanN7 why was this merged without a spec PR for the traits? |
@thewilsonator Walter has complained about this PR stalling other work. The bitfields DIP hasn't been accepted yet so it might be the case that all of this is reverted anyway. Once the DIP is accepted we can take care of the spec PR, or if it gets rejected then no harm was done. I agree that the best approach here would have been to also have a spec PR, however, I took Walter's annoyance into account and decided to merge this as is. |
Adds bitfield introspection capabilities as described:
https://github.com/WalterBright/documents/blob/master/bitfields.md