-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify union evc #16502
simplify union evc #16502
Conversation
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16502" |
Looks like valgrind doesn't like this change. |
25ea36f
to
4741a3e
Compare
@ibuclaw any idea what the persistent failure on |
Could be https://gcc.gnu.org/PR92309 |
@RazvanN7 did you merge when there are failing pipelines? |
I was under the impression that the failure is unrelated. |
This reverts commit 35bcd18.
Redone in #16518 |
@RazvanN7 what was the actual problem? |
possibly #16502 (comment) |
That can be checked by replacing the anonymous union with a named union field + alias this. If found to be the case, then not much can do about it. I didn't have the foresight to backport the fix to the 9 release branch four years ago, and its frozen/closed now. You can always use |
Ah. Thanks for getting it fixed! |
No description provided.